Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMake flags for PyBind11 linking. #527

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Update CMake flags for PyBind11 linking. #527

merged 3 commits into from
Feb 19, 2020

Conversation

guacke
Copy link
Contributor

@guacke guacke commented Feb 19, 2020

Short description
This PR updates the installation instructions with additional guidelines on how to link to PyBind11.

Related issues

Additional context
The underlying problem is marked as wontfix by PyBind11 pybind/pybind11#99.

Don't forget:

  • if new files are created: update the Doxygen file, the collective gqcp.hpp header and the CMake files
  • update the documentation on our website and check if new Python bindings should be added

lelemmen
lelemmen reviewed Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@lelemmen lelemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after minor modifications.

INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
@guacke guacke requested a review from lelemmen February 19, 2020 17:29
lelemmen
lelemmen approved these changes Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@lelemmen lelemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding an example for a full cmake .. command!

@guacke guacke merged commit 5fd330d into develop Feb 19, 2020
@guacke guacke deleted the feature/pybind branch February 19, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lelemmen lelemmen lelemmen approved these changes

@xdvriend xdvriend Awaiting requested review from xdvriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guacke @lelemmen